Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revise how deno task check:types is performed #683

Merged
merged 3 commits into from
Aug 28, 2024
Merged

fix: revise how deno task check:types is performed #683

merged 3 commits into from
Aug 28, 2024

Conversation

killtheliterate
Copy link
Contributor

No description provided.

iuioiua
iuioiua reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, for the delayed review. This seems like a small step backward, as the previous task checked other files besides those that are actually run when the server is started. E.g. files in the tasks folder.

@killtheliterate
Copy link
Contributor Author

This PR was opened in response to this conversation in the deno discord -> https://discord.com/channels/684898665143206084/1274145552082272277/1274271119746142228

 deno task check
Task check deno check **/*.ts && deno check **/*.tsx
Error launching 'deno': Argument list too long (os error 7)

@iuioiua iuioiua changed the title fix: revise how deno task check:types is performed fix: revise how deno task check:types is performed Aug 28, 2024
iuioiua
iuioiua approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Thank you!

@iuioiua iuioiua merged commit 442871e into denoland:main Aug 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@killtheliterate @iuioiua